-
Notifications
You must be signed in to change notification settings - Fork 155
feat: Adding sample automation for PR #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage after merging feat/pr_automation into main
Coverage Report
|
Coverage after merging feat/pr_automation into main
Coverage Report
|
- uses: actions/checkout@v2 | ||
- name: Install packages | ||
run: | | ||
export NODE_ENV=dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd consider setting the environment variable like so
runs-on: ubuntu-latest
env:
NODE_ENV: dev
steps:
...
Coverage after merging feat/pr_automation into main
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great!
Coverage after merging feat/pr_automation into main
Coverage Report
|
Coverage after merging feat/pr_automation into main
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of your changes
Proposal for automating tests for PRs
How to verify this change
Related issues, RFCs
#120
PR status
Is this ready for review?: NO
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.