Skip to content

Maintenance: have descriptive logs in the integration tests #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dreamorosi opened this issue Apr 29, 2022 · 3 comments
Closed

Maintenance: have descriptive logs in the integration tests #825

dreamorosi opened this issue Apr 29, 2022 · 3 comments
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped good-first-issue Something that is suitable for those who want to start contributing internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Description of the feature request

Problem statement
Now that we are running more integration tests (multiple runtimes for each utility) and in parallel it would be beneficial to have logs that explicitly indicate which utility they belong to. This would help troubleshoot faster in case of issues.

Summary of the feature
Currently this is how the log prefix are:
image

Ideally we could have something like:

[logger:e2e:nodejs14x]
[tracer:e2e:nodejs14x]
[metrics:e2e:nodejs12x]

Code examples
N/A

Benefits for you and the wider AWS community
N/A - this change concerns mainly maintainers.

Describe alternatives you've considered
None / scroll through the logs

Additional context
N/A

Related issues, RFCs

N/A

@dreamorosi dreamorosi added good-first-issue Something that is suitable for those who want to start contributing utility:all automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Apr 29, 2022
@ijemmy
Copy link
Contributor

ijemmy commented May 2, 2022

GitHub matrix strategy may be a better approach. It will fix this issue and be more efficient. I'm looking into that.

@dreamorosi
Copy link
Contributor Author

With the implementation of the matrix strategy merged in #828 we now have a better separation of the tests that makes it immediately clear which logs you're looking at, we can close this issue as resolved.

image

@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi changed the title Feature (all): have descriptive logs in the integration tests Maintenance: have descriptive logs in the integration tests Nov 14, 2022
@dreamorosi dreamorosi added the completed This item is complete and has been merged/shipped label Nov 14, 2022
@dreamorosi dreamorosi moved this from Closed to Shipped in AWS Lambda Powertools for TypeScript Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped good-first-issue Something that is suitable for those who want to start contributing internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

No branches or pull requests

2 participants