Skip to content

fix: Logger string interpolation to main reserved keys only #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 2, 2020
Merged

fix: Logger string interpolation to main reserved keys only #53

merged 4 commits into from
Jun 2, 2020

Conversation

heitorlessa
Copy link
Contributor

Issue #, if available: #38

Description of changes:

  • Minor: Fix Logger casting
  • Minor: Fix Logger cold_start as bool instead of str
  • Minor: Fix Logger function_memory_size as int instead of str
  • Update tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@heitorlessa heitorlessa requested a review from to-mc June 2, 2020 17:38
@heitorlessa heitorlessa removed the request for review from to-mc June 2, 2020 17:48
@heitorlessa heitorlessa merged commit 0cd7602 into develop Jun 2, 2020
@heitorlessa heitorlessa deleted the fix/logger-value-coercion branch June 2, 2020 17:48
@heitorlessa heitorlessa changed the title Fix Logger value coercion to main keys fix: Logger value coercion to main reserved keys only Jun 3, 2020
@heitorlessa heitorlessa changed the title fix: Logger value coercion to main reserved keys only fix: Logger string interpolation to main reserved keys only Jun 3, 2020
heitorlessa added a commit that referenced this pull request Jun 10, 2020
@heitorlessa
Merge branch 'develop'
8ae86bd 
* develop:
  chore: plat wheels are not needed
  Fix Logger value coercion to main keys (#53)
  fix: cast dimension value to str to avoid issue where EMF silently fails (#52)
heitorlessa referenced this pull request in heitorlessa/aws-lambda-powertools-python Jun 17, 2020
@heitorlessa
Fix Logger value coercion to main keys (#53)
5618965 
* fix: str formatting for reserved keys only #38

* fix: cold_start value from str to actual bool  #38

* fix: memory_size value from str to actual int #38

* chore: linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmoutschen nmoutschen nmoutschen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heitorlessa @nmoutschen