Skip to content

chore(ci): address ossf scorecard findings on npm, pip, and top-level permission leftover #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/publish_v2_layer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
# therefore it ignores both activated virtual env and cached interpreter by GH
run: |
poetry export --format requirements.txt --output requirements.txt
pip install -r requirements.txt
pip install --require-hashes -r requirements.txt
- name: Set up QEMU
uses: docker/setup-qemu-action@2b82ce82d56a2a04d2637cd93a637ae1b359c0a7 # v2.0.0
with:
Expand All @@ -101,7 +101,7 @@ jobs:
- name: install cdk and deps
working-directory: ./
run: |
npm install
npm ci
npx cdk --version
- name: CDK build
run: npx cdk synth --verbose --context version="${{ inputs.latest_published_version }}" -o cdk.out
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/reusable_deploy_v2_layer_stack.yml
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,11 @@ jobs:
# therefore it ignores both activated virtual env and cached interpreter by GH
run: |
poetry export --format requirements.txt --output requirements.txt
pip install -r requirements.txt
pip install --require-hashes -r requirements.txt
- name: install cdk and deps
working-directory: ./
run: |
npm install
npm ci
npx cdk --version
- name: install deps
run: poetry install
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/reusable_publish_docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,7 @@ on:
default: develop

permissions:
id-token: write # trade JWT token for AWS credentials in AWS Docs account
contents: write # push to gh-pages
pages: write # deploy gh-pages website
contents: read

jobs:
publish_docs:
Expand All @@ -40,6 +38,10 @@ jobs:
group: on-docs-rebuild
runs-on: ubuntu-latest
environment: "Docs"
permissions:
contents: write # push to gh-pages
id-token: write # trade JWT token for AWS credentials in AWS Docs account
pages: write # uncomment if mike fails as we migrated to S3 hosting
steps:
- uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
with:
Expand Down Expand Up @@ -110,7 +112,7 @@ jobs:
# 1. Download the versions.json file from S3
# 2. Find any reference to the alias and delete it from the versions file
# 3. This is voodoo (don't use JQ):
# - we assign the input as $o and the new version/alias as $n,
# - we assign the input as $o and the new version/alias as $n,
# - we check if the version number exists in the file already (for republishing docs)
# - if it's an alias (stage/latest/*) or old version, we do nothing and output $o (original input)
# - if it's a new version number, we add it at position 0 in the array.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
node-version: "16.12"
- name: Install CDK CLI
run: |
npm install
npm ci
npx cdk --version
- name: Install dependencies
run: make dev
Expand Down
13 changes: 13 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,8 @@
"version": "1.0.0",
"devDependencies": {
"aws-cdk": "^2.86.0"
},
"dependencies": {
"package-lock.json": "^1.0.0"
}
}