docs(homepage): fix the link in the end-of-support v1 banner #1892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrodamascena
requested review from
heitorlessa
and removed request for
a team
boring-cyborg
bot
added
the
documentation
pull-request-size
bot
added
the
size/XS
rubenfonseca
suggested changes
Feb 3, 2023
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| {% block announce %} | |||
| 👋 Powertools for Python v1 will no longer receive updates or releases after 31/03/2023! | |||
| We encourage you to read our <a href="/upgrade/#end-of-support-v1">upgrade guide on how to migrate to v2</a>. | |||
| We encourage you to read our <a href="https://awslabs.github.io/aws-lambda-powertools-python/latest/upgrade/#end-of-support-v1">upgrade guide on how to migrate to v2</a>. | |||
There was a problem hiding this comment.
Could #1893 be a better solution?
1 task
|
Closed in favour of #1893 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1891
Summary
Changes
The link has a problem when the user is browsing a page outside the homepage
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.