fix(idempotency): compute hashes once to guard against inadvert mutat… #1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions This protects against functions that inadvertently change the incoming event data
pull-request-size
bot
added
the
size/M
|
Thanks again @ojongerius - Closing in favour of #1090, where it's less performant but easier to maintain (we're also changing private to public methods here) |
|
All good, it was just a sketch. As this modules evolves switching to computing once could be taken into account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ions
This protects against functions that inadvertently change the incoming event data
Alternate fix for #1093
Description of changes:
Calculate hashes once, this protects against event data being changed, but uses less system resources (memory by preventing a
copy.deepcopy()and cpu by not recomputing hashes.Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.