Upgrade to mio 0.7 #742
Closed
Upgrade to mio 0.7 #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goffrie
reviewed
Apr 21, 2020
| // Deregister the I/O object from the mio instance. | ||
| self.poller.deregister(source)?; | ||
| self.poller.lock().unwrap().registry().deregister(source)?; |
There was a problem hiding this comment.
this seems wrong - register/deregister will have to wait until any current poll finishes, to acquire the lock?
There was a problem hiding this comment.
More information on this. Discussion is here.
|
closing in favor of #757 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiles, but seems something about handling socket connections has changed that needs further debugging.
Mio returns now
mio::net::SocketAddrs, which can not be converted easily tostdversions, this needs some more investigation.Update TCP tests are passing now, still one issue with UDS.
Closes #717