Skip to content

Small example for a TCP server that both handles IP v4 and v6 #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Nov 1, 2019

Conversation

skade
Copy link
Collaborator

@skade skade commented Oct 30, 2019

This works quite nicely through Stream#merge.

@skade skade closed this Oct 30, 2019
Presenting stream merge on Incoming.
@skade skade reopened this Oct 30, 2019
@skade skade force-pushed the tcp-server-ipv6-ipv4 branch from 51ca48c to e37780b Compare October 30, 2019 16:51
@ghost
Copy link

ghost commented Nov 1, 2019

I like this!

We should change CI to use --features unstable because this PR is currently failing due to the use of unstable features in examples.

@skade
Copy link
Collaborator Author

skade commented Nov 1, 2019

We currently have a check and a check unstable step, but that doesn't properly cover examples. :/

@ghost
Copy link

ghost commented Nov 1, 2019

@skade Can you edit .github/workflows/ci.yml and change this:

    - name: check
      uses: actions-rs/cargo@v1
      with:
        command: check
        args: --all --bins --examples

to this:

    - name: check
      uses: actions-rs/cargo@v1
      with:
        command: check
        args: --all --bins --tests

Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this example a lot!

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this. CI passes except for netlify, which is currently broken.

@ghost ghost merged commit d5fd035 into async-rs:master Nov 1, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants