Skip to content

Performance regression with new scheduler #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dignifiedquire opened this issue Apr 9, 2020 · 1 comment · Fixed by #747
Closed

Performance regression with new scheduler #746

dignifiedquire opened this issue Apr 9, 2020 · 1 comment · Fixed by #747

Comments

@dignifiedquire
Copy link
Member

It turns out that #733 introduced quite the performance regression on various http benchmarks, > 50% on https://github.com/stjepang/minihttp/

I have tracked the issue down to this commit: f960776

If I revert it, all tests still pass and performance improves to be even slightly faster than 1.5.

@k-nasa could you shed some light what exactly you were trying to achieve in this commit and why you introduced it?

dignifiedquire added a commit that referenced this issue Apr 9, 2020
This now matches more closely the logic as implemented in #631, and fixes the performance regression as far as I have observed.

Closes #746
@dignifiedquire
Copy link
Member Author

@k-nasa I figured out you were trying to match the original PR, I think you didn't match the exact logic, which resulted in the perf regression. Please checkout out #747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant