-
Notifications
You must be signed in to change notification settings - Fork 340
Some typos and improvements for the book #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Lonami hi! Thanks so much for opening this! -- I noticed you never got around to following this up with a PR. Are you still interested in doing so? Is there anything we can do to help? Thanks heaps! |
I did not intend making a PR myself. Rather, I wanted to document a few mistakes, and maybe other people found more. Once we felt they were enough to fix, then anyone could open said PR :) |
@Lonami ah yeah that makes sense -- I'll mark this as "help wanted" then so someone who wants to contribute can pick this up. Thanks heaps! |
Hello! Can I pick this up then? 😄 |
Sure! Looking forward to the patches 🙂.
…________________________________
From: André Zanellato <[email protected]>
Sent: Saturday, October 5, 2019 1:12 PM
To: async-rs/async-std <[email protected]>
Cc: Subscribed <[email protected]>
Subject: Re: [async-rs/async-std] Some typos and improvements for the book (#68)
Hello! Can I pick this up then? 😄
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#68?email_source=notifications&email_token=AAALTNXOGWS2RRDBSILOJRLQNBZB3A5CNFSM4IMPB72KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANQBTI#issuecomment-538640589>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAALTNV5AUVTM42BJROIOKDQNBZB3ANCNFSM4IMPB72A>.
|
Bump to v1.6.0
Collecting a few of them here before making a single commit with all fixes:
In general, Title Case is not followed consistently for titles.
std::future
andfutures-rs
There are two periods when there should be either one or three.
Stability and SemVer
Typo for "introduce".
This sounds a bit off to me. Maybe "we will give a notice at least 3 months ahead" is better.
Futures
The list that follows starts its items with a lowercase letter. However, the list immediately below starts them with an uppercase letter. This is a bit distracting, and not consistent. Perhaps using a sentence is more appropriated, such as "Computation is a sequence of composable operations which can branch based on a decision, and either run to succession and yield a result, or they can yield an error".
Probably something like "and how to react on potential events in the… well,
Future
" is better.I noticed here that code blocks are not syntax-highlighted. Is there a reason for this?
That's not the case though, is it? The function is
async fn ... -> Result<String, io::Error>
, notasync fn ... -> String
.Should that be "available some time later" or "some later time"?
A bit earlier it was said that calling
poll
repeatedly was enough to drive a future to completion. So is "need" the right word here?Tasks
"Now" is repeated too soon. Maybe "Now that we know what Futures are, we want to run them!" works better.
Task can also have a name.
They carry.
task API.
with the concurrent.
Missing space after the comma.
The text was updated successfully, but these errors were encountered: