Skip to content

Making sure save is disabled #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 14, 2023
Merged

Making sure save is disabled #35

merged 3 commits into from
Feb 14, 2023

Conversation

murilopolese
Copy link
Contributor

When selected device is disk and there is no folder selected, the save button shouldn't be clickable

@murilopolese
Making sure save is disabled
e8bb033 
When selected device is disk and there is no folder selected, the save button shouldn't be clickable
@murilopolese murilopolese mentioned this pull request Feb 6, 2023
Closed
@murilopolese murilopolese requested a review from ubidefeo February 6, 2023 15:46
@murilopolese
Copy link
Contributor Author

#33

@ubidefeo
Copy link
Collaborator

ubidefeo commented Feb 7, 2023

this can still be triggered, although in a convoluted way

  • open Editor
  • do not select folder
  • rename undefined to something
  • Save button is still disabled
  • click on the file name again
  • Save button is enabled and can save
SaveButtonDisabled.mp4

@murilopolese
Copy link
Contributor Author

this can still be triggered, although in a convoluted way

Thanks for catching this one, I made a mistake on the logic but now it should be fixed. Can you break it, @ubidefeo ?? hehehe

ubidefeo
ubidefeo approved these changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murilopolese murilopolese merged commit d63e565 into main Feb 14, 2023
@per1234 per1234 added the bug Something isn't working label Feb 14, 2023
@murilopolese murilopolese deleted the bugfix/save-without-selecting-folder branch February 14, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@murilopolese @ubidefeo @per1234