Skip to content

Fix event handlers for file save and upload #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

sebromero
Copy link
Collaborator

This PR fixes an issue that causes the file transfer to fail. Reason is that the function callbacks cannot be serialized and need to be replaced with the IPC event handling system.

@sebromero sebromero requested a review from ubidefeo December 18, 2024 19:30
Copy link
Collaborator

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression fixed
tested on Mac/Linux/Windows

@sebromero sebromero merged commit 8268359 into development Dec 18, 2024
10 of 11 checks passed
@sebromero sebromero deleted the bugfix/fix-file-transfer branch December 19, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants