Correct package index schema's regex for size property #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `packages[].platforms[].size` and `packages[].tools[].systems[].size` properties are string representations of integers, and thus must consist solely of the characters 0-9. The previous regular expression for a valid size value only required that a number be found somewhere in the string.
Codecov Report
@@ Coverage Diff @@
## main #197 +/- ##
=======================================
Coverage 85.17% 85.17%
=======================================
Files 43 43
Lines 3392 3392
=======================================
Hits 2889 2889
Misses 392 392
Partials 111 111
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
umbynos
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
packages[].platforms[].sizeandpackages[].tools[].systems[].sizeproperties are string representations ofintegers, and thus must consist solely of the characters 0-9. The previous regular expression for a valid size value only
required that a number be found somewhere in the string.