Skip to content

remove old unused tasks, .PRETTIER was not even defined #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Feb 22, 2022

Probably some leftover from some copy/paste. The removed tasks were not working and should be superseded by markdown: ones

@umbynos umbynos added the topic: infrastructure Related to project infrastructure label Feb 22, 2022
@umbynos umbynos self-assigned this Feb 22, 2022
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the reference to the docs:check task here:

- task: docs:check

There is no replacement because the new approach is to just do the formatting, since in the case of Prettier I don't see the point in a manually run non-invasive check.

The system I have evolved for the projects where I am the primary maintainer is placing the tasks under one of two "umbrella" convenience tasks depending on their behavior:

  • check - Detect problems that can not be corrected automatically.
  • fix - Make automated corrections.

So I call the general:format-prettier task from the fix umbrella task. But I consider the "umbrella" tasks to be a matter of preference for the primary maintainer of each project to set if and how they like.

@umbynos umbynos merged commit 06413de into main Feb 23, 2022
@umbynos umbynos deleted the umbynos/cleanup_task branch February 23, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants