-
-
Notifications
You must be signed in to change notification settings - Fork 404
[skip changelog] Introduce linting and formatting for docs and config files #836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
silvanocerza
merged 11 commits into
arduino:master
from
silvanocerza:docs-config-formatting
Jul 21, 2020
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
63b0eb6
[skip changelog] Add linting/formatting tasks and CI checks for docs …
silvanocerza 87a672f
[skip changelog] Format all docs and config files
silvanocerza 53d8263
[skip changelog] Update contributing documentation with formatting in…
silvanocerza 46ecd7c
[skip changelog] Fix some Prettier configuration issues
silvanocerza 1829d7b
[skip changelog] Format all config files
silvanocerza 98b182f
[skip changelog] Fix documentation indentation issue
silvanocerza a2f4b19
[skip changelog] Removed files from .prettierignore
silvanocerza cd0ce92
[skip changelog] Update docs/package_index_json-specification.md
silvanocerza 668f832
[skip changelog] Format PR and issues templates
silvanocerza 404b834
[skip changelog] Format files after rebase
silvanocerza 11d7ac9
[skip changelog] Update .prettierrc and reformat everything
silvanocerza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,25 @@ | ||
--- | ||
name: 🐛 Bug Report | ||
about: If something isn't working as expected 🤔. | ||
|
||
--- | ||
|
||
## Bug Report | ||
|
||
### Current behavior | ||
<!-- Paste the full command you run --> | ||
|
||
<!-- Paste the full command you run --> | ||
|
||
<!-- Add a clear and concise description of the behavior. --> | ||
|
||
|
||
### Expected behavior | ||
<!-- Add a clear and concise description of what you expected to happen. --> | ||
|
||
<!-- Add a clear and concise description of what you expected to happen. --> | ||
|
||
### Environment | ||
|
||
- CLI version (output of `arduino-cli version`): | ||
- OS and platform: | ||
|
||
### Additional context | ||
|
||
<!-- (Optional) Add any other context about the problem here. --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,31 +1,26 @@ | ||
**Please check if the PR fulfills these requirements** | ||
- [ ] The PR has no duplicates (please search among the [Pull Requests](https://github.com/arduino/arduino-cli/pulls) before creating one) | ||
|
||
- [ ] The PR has no duplicates (please search among the [Pull Requests](https://github.com/arduino/arduino-cli/pulls) | ||
before creating one) | ||
- [ ] The PR follows [our contributing guidelines](https://arduino.github.io/arduino-cli/CONTRIBUTING/#pull-requests) | ||
- [ ] Tests for the changes have been added (for bug fixes / features) | ||
- [ ] Docs have been added / updated (for bug fixes / features) | ||
|
||
|
||
* **What kind of change does this PR introduce?** | ||
<!-- Bug fix, feature, docs update, ... --> | ||
|
||
|
||
* **What is the current behavior?** | ||
- **What is the current behavior?** | ||
<!-- You can also link to an open issue here --> | ||
|
||
|
||
* **What is the new behavior?** | ||
<!-- if this is a feature change --> | ||
|
||
|
||
|
||
* **Does this PR introduce a breaking change?** | ||
- **Does this PR introduce a breaking change?** | ||
<!-- What changes might users need to make in their workflow or application due to this PR? --> | ||
|
||
|
||
|
||
* **Other information**: | ||
<!-- Any additional information that could help the review process --> | ||
|
||
|
||
--- | ||
|
||
See [how to contribute](https://arduino.github.io/arduino-cli/CONTRIBUTING/) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
name: "Verify files formatting" | ||
|
||
on: | ||
push: | ||
paths: | ||
- "**/*.md" | ||
- "**/*.yml" | ||
- "**/*.yaml" | ||
- ".prettierrc" | ||
- ".prettierignore" | ||
pull_request: | ||
paths: | ||
- "**/*.md" | ||
- "**/*.yml" | ||
- "**/*.yaml" | ||
- ".prettierrc" | ||
- ".prettierignore" | ||
|
||
jobs: | ||
verify-formatting: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@master | ||
|
||
- name: Install Taskfile | ||
uses: Arduino/actions/setup-taskfile@master | ||
with: | ||
repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
- name: Verify formatting of all files | ||
run: task docs:check config:check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# IDE files | ||
.idea/ | ||
.vscode/ | ||
.vs/ | ||
.ionide/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"semi": false, | ||
"printWidth": 120, | ||
"overrides": [ | ||
{ | ||
"files": "*.md", | ||
"options": { | ||
"proseWrap": "always" | ||
} | ||
} | ||
] | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.