Fix handling of referenced cores #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tests for ResolveFQBN (which returns more details than the FindBoardWithFQBN that was already tested), but also adds an extra boards.txt with boards that are derived from another platform/core (i.e. have `build.core=package:core`. These new tests are currently failing, because of a bug and insufficient error handling, which will be fixed in subsequent commits.
A core is referenced by specifying `build.core=package:core` in board properties. However, the code used the second part (core) both for looking up the the package, as well as for the core to use from that package. The most commonly used core reference is `arduino:arduino` which works because both parts are identical, which is probably why this bug has not shown up before. This commit fixes the bug by simply using the right part to look up the package.
This used to say e.g. missing platform adafruit:referenced:avr required for build where two packagenames (adafruit and referenced) were joined together which makes no sense. Now, it just mentions the missing package, and the fqbn that references it.
Before, when a platform was referenced through a `build.core` and the package was present by the platform/architecure was missing, a nullpointer was passed to GetInstalledPlatformRelease, which would segfault. Now, a proper error message is returned.
|
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A core is referenced by specifying
build.core=package:corein board properties. However, the code that handled resolving these, had two problems:core) rather than the first part (package) to look up the package to reference. The most commonly used core reference isarduino:arduinowhich works because both parts are identical. However, when referencing cores where the core name does not equal the package name (e.g. the Adafruit or STM32 cores), there is no way to actually reference such a core properly.This PR fixes both problems, and additionally adds a testcase for
ResolveFQBNthat exposes these problems (and tests some other cases as well).