Skip to content

Minor code documentation enhancements #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2018
Merged

Minor code documentation enhancements #46

merged 2 commits into from
Sep 25, 2018
+42 −42

Conversation

eduherminio
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cmaglie
Copy link
Member

cmaglie commented Sep 24, 2018

Could you redo the commit keeping only the changes outside the vendor folder?

The vendor folder contains a snapshot of the libraries used by the cli, so they should be fixed upstream (and updated here later).

@cmaglie cmaglie added this to the Next alpha.preview milestone Sep 24, 2018
@eduherminio
Copy link
Contributor Author

Could you redo the commit keeping only the changes outside the vendor folder?

Sure, done!

@cmaglie cmaglie merged commit cba8e64 into arduino:master Sep 25, 2018
per1234 added a commit that referenced this pull request Aug 9, 2021
@per1234
Merge pull request #46 from arduino/per1234/architectures-schema-checks
5e3bbff 
Add schema provided checks for library.properties architectures field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0-alpha.preview
Development

Successfully merging this pull request may close these issues.
3 participants
@eduherminio @CLAassistant @cmaglie