Fix logging from low level operations #364
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
reviewed
Aug 28, 2019
| // Fprintln is supposed to let the caller decide the target, let's not do it | ||
| // and just forward to Println | ||
| func (l LegacyLogger) Fprintln(w io.Writer, level string, format string, a ...interface{}) { | ||
| l.Println(level, format, a...) |
There was a problem hiding this comment.
I think that this will create some regressions because the parameter w must be considered to redirect the output to the correct stream... the legacy i18n module is really a mess, let's have a call to plan a way to migrate to a saner logging infra.
per1234
added
conclusion: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174
This PR provides a wrapper around logrus to be used by the legacy package. This way, the global
-vand--log-leveloptions will be actually used by the low level packages underlegacy, along with all the logging setup we already do at the CLI level.