[breaking] Refactoring of download subroutines #1697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
force-pushed
the
refactor_downloaders
branch
3 times, most recently
from
af91a95 to
9334716
Compare
cmaglie
force-pushed
the
refactor_downloaders
branch
from
9334716 to
c46f8fd
Compare
per1234
requested changes
Apr 8, 2022
httpclient is now under arduino/httpclient. Some configuration values have been moved under 'configuration' package, and the related subroutines have been refactored.
Co-authored-by: per1234 <[email protected]>
cmaglie
force-pushed
the
refactor_downloaders
branch
from
c46f8fd to
69c5fd0
Compare
per1234
approved these changes
Apr 11, 2022
umbynos
reviewed
Apr 12, 2022
umbynos
reviewed
Apr 12, 2022
umbynos
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
The subroutines that perform download of archives and indexes have been factored.
What is the current behavior?
No changes in behavior
What is the new behavior?
No changes in behavior
Does this PR introduce a breaking change, and is titled accordingly?
Some functions or methods have been moved and/or changed signature.