Skip to content

[skip changelog] Sync certificate check CI workflow with template #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Aug 9, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Infrastructure update

  • What is the current behavior?

We have assembled a collection of reusable GitHub Actions workflows:
https://github.com/arduino/tooling-project-assets
These workflows will be used in the repositories of all Arduino tooling projects.

Some minor improvements and standardizations have been made in the upstream "template" workflow, but have not yet been pulled into this repository.

  • What is the new behavior?

Workflow is synced with the state of the art from upstream.
Notable:

  • Trigger workflow run on modification to facilitate testing.

    • The CI run for this PR demonstrates it in action. I submitted it from a branch of this repo for that purpose. It is configured to not run for PRs submitted from forks because they don't have access to the required repository secrets.
  • repository_dispatch event trigger to allow for automated triggering across many repositories via the GitHub API following a relevant external change.

  • Change Slack webhook repository secret name.

    • I have already created the new secret and will remove the old one after this is merged.
  • Use major version ref of rtCamp/action-slack-notify so that the latest release of the action is used up to the next major bump.

  • Does this PR introduce a breaking change, and is
    titled accordingly?

Does this PR introduce a breaking change

No

is titled accordingly

Yes

@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Aug 9, 2021
@per1234 per1234 requested review from silvanocerza and umbynos August 9, 2021 05:06
We have assembled a collection of reusable GitHub Actions workflows:
https://github.com/arduino/tooling-project-assets
These workflows will be used in the repositories of all Arduino tooling projects.

Some minor improvements and standardizations have been made in the upstream "template" workflow, and those are introduced to this repository via this pull request.
Notable:

- Trigger workflow run on modification to facilitate testing.
- `repository_dispatch` event trigger to allow for automated triggering across many repositories via the GitHub API following a relevant external change.
- Change Slack webhook repository secret name.
- Use major version ref of `rtCamp/action-slack-notify` so that the latest release of the action is used up to the next major bump.
@per1234 per1234 force-pushed the per1234/check-certificates branch from a5b5346 to 2664aef Compare August 9, 2021 08:39
@per1234 per1234 changed the title Sync certificate check CI workflow with template [skip changelog] Sync certificate check CI workflow with template Aug 9, 2021
@per1234 per1234 merged commit 0db96b3 into master Aug 9, 2021
@per1234 per1234 deleted the per1234/check-certificates branch August 9, 2021 10:05
@per1234 per1234 self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants