Skip to content

Regression in 0.3.1 - can't upload on any board #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brusherru opened this issue Oct 10, 2018 · 6 comments
Closed

Regression in 0.3.1 - can't upload on any board #65

brusherru opened this issue Oct 10, 2018 · 6 comments
Labels
conclusion: invalid Issue/PR not valid

Comments

@brusherru
Copy link

brusherru commented Oct 10, 2018

Env

Windows 10
[email protected]

Problem

Installing, compiling and etc works fine.
But when I try to upload compiled sketch onto my board (arduino:avr:leonardo) it throws:

panic: assignment to entry in nil map

goroutine 1 [running]:
github.com/arduino/arduino-cli/vendor/github.com/arduino/go-properties-orderedmap.(*Map).Set(0x11f1be6c, 0x120120b2, 0x4, 0x120120b7, 0x12)
        /home/jenkins/workspace/arduino-cli/src/github.com/arduino/arduino-cli/vendor/github.com/arduino/go-properties-orderedmap/properties.go:226 +0x76
github.com/arduino/arduino-cli/vendor/github.com/arduino/go-properties-orderedmap.(*Map).Merge(0x11f1be6c, 0x11f1be58, 0x1, 0x1, 0x11e04e50)
        /home/jenkins/workspace/arduino-cli/src/github.com/arduino/arduino-cli/vendor/github.com/arduino/go-properties-orderedmap/properties.go:396 +0x7d
github.com/arduino/arduino-cli/commands/upload.run(0x11f53680, 0x11e43aa0, 0x1, 0x5)
        /home/jenkins/workspace/arduino-cli/src/github.com/arduino/arduino-cli/commands/upload/upload.go:165 +0x3ac
github.com/arduino/arduino-cli/vendor/github.com/spf13/cobra.(*Command).execute(0x11f53680, 0x11e43a70, 0x5, 0x6, 0x11f53680, 0x11e43a70)
        /home/jenkins/workspace/arduino-cli/src/github.com/arduino/arduino-cli/vendor/github.com/spf13/cobra/command.go:760 +0x20e
github.com/arduino/arduino-cli/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x11e5f040, 0x11f52640, 0x11e5fb80, 0x11e5f7c0)
        /home/jenkins/workspace/arduino-cli/src/github.com/arduino/arduino-cli/vendor/github.com/spf13/cobra/command.go:846 +0x28a
github.com/arduino/arduino-cli/vendor/github.com/spf13/cobra.(*Command).Execute(0x11e5f040, 0x8f26b8, 0x8f3494)
        /home/jenkins/workspace/arduino-cli/src/github.com/arduino/arduino-cli/vendor/github.com/spf13/cobra/command.go:794 +0x21
main.main()
        /home/jenkins/workspace/arduino-cli/src/github.com/arduino/arduino-cli/main.go:30 +0x1f
@cmaglie
Copy link
Member

cmaglie commented Oct 11, 2018

I should have fixed this in 0.3.1 😨, let me do a quick check...

@brusherru
Copy link
Author

@cmaglie it looks like 0.3.1 differs from 0.3.0 only by changes in the README.md 🤔

@per1234
Copy link
Contributor

per1234 commented Oct 11, 2018

@brusherru here's the important commit between 0.3.0-alpha.preview and 0.3.1-alpha.preview that should have fixed this problem (it did for me at least): 5fc6787

@cmaglie
Copy link
Member

cmaglie commented Oct 11, 2018

@brusherru I've just tried 0.3.1 on a windows machine and it seems to work as expected, may you double check if it is really a 0.3.1 and not a 0.3.0? try to run arduino-cli version to be 100% sure.

@brusherru
Copy link
Author

@cmaglie @per1234 oh, you're right. It's my failure. Sorry 🙈

@cmaglie
Copy link
Member

cmaglie commented Oct 11, 2018

No problem, and thanks for all your feedback 👍

@per1234 per1234 added the conclusion: invalid Issue/PR not valid label Oct 11, 2018
per1234 pushed a commit that referenced this issue Nov 16, 2020
per1234 added a commit that referenced this issue Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid
Projects
None yet
Development

No branches or pull requests

3 participants