Watchdog handling cleanup

[pennam]

Aim of this pr is to cleanup watchdog handling replacing architecture specific function calls with an unique implementation that actually takes care of the architecture.

I've added also an out of scope commit that fixes the declared NANO_RP2040 maximum watchdog timeout.

I didn't change the mbed_watchdog_trigger_reset function with the hope to find a better fix in the future and remove it.

I'm opening as a draft to start testing.

Board	Result
NANO RP2040	✔️
PORTENTA H7
NANO 33 IoT	✔️
MKR WIFI 1010	✔️

[aentinger]

Great work! I ❤️ it.

[aentinger]

If the tests work, its good to merge 👍

[pennam]

Thanks, i will try to add the test results as soon as possible. I'm still having troubles connecting to create.arduino.cc

[github-actions]

Memory usage change @ 936b75c

Board	flash	%	RAM for global variables	%
arduino:samd:mkr1000	🔺 +8 - +8	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/ArduinoIoTCloud-Advanced flash	%	examples/ArduinoIoTCloud-Advanced RAM for global variables	%	examples/ArduinoIoTCloud-Basic flash	%	examples/ArduinoIoTCloud-Basic RAM for global variables	%	examples/utility/ArduinoIoTCloud_Travis_CI flash	%	examples/utility/ArduinoIoTCloud_Travis_CI RAM for global variables	%	examples/utility/Provisioning flash	%	examples/utility/Provisioning RAM for global variables	%
arduino:samd:mkr1000	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0
arduino:samd:mkrwan1300	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%
arduino:samd:mkr1000,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,

[pennam]

I've added a commit that should take care of your changes here https://github.com/arduino-libraries/WiFiNINA/pull/182/files
I was unsure on how to handle library compatibility so i've added this define WIFI_HAS_FEED_WATCHDOG_FUNC to make sure to not break anything. Doing this way it needs also to be added into the WiFi NINA library pennam/WiFiNINA@6780013

I did not remove this additional watchdog feed

ArduinoIoTCloud/src/ArduinoIoTCloudTCP.cpp

Lines 323 to 331 in d09c6dc

	/* This watchdog feed is actually needed only by the RP2040 CONNECT cause its
	* maximum watchdog window is 8388ms; despite this we feed it for all
	* supported ARCH to keep code aligned.
	*/
	#ifdef ARDUINO_ARCH_SAMD
	samd_watchdog_reset();
	#elif defined(ARDUINO_ARCH_MBED)
	mbed_watchdog_reset();
	#endif

otherwise i still get some resets.

[github-actions]

Memory usage change @ 616a4fe

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m4	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed:envie_m7	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	🔺 +8 - +8	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrgsm1400	🔺 +8 - +8	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrnb1500	🔺 +8 - +8	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	🔺 0 - +8	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:nano_33_iot	🔺 0 - +8	0.0 - 0.0	0 - 0	0.0 - 0.0
esp32:esp32:esp32	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
esp8266:esp8266:huzzah	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/ArduinoIoTCloud-Advanced flash	%	examples/ArduinoIoTCloud-Advanced RAM for global variables	%	examples/ArduinoIoTCloud-Basic flash	%	examples/ArduinoIoTCloud-Basic RAM for global variables	%	examples/utility/ArduinoIoTCloud_Travis_CI flash	%	examples/utility/ArduinoIoTCloud_Travis_CI RAM for global variables	%	examples/utility/Provisioning flash	%	examples/utility/Provisioning RAM for global variables	%	examples/utility/SelfProvisioning flash	%	examples/utility/SelfProvisioning RAM for global variables	%
arduino:mbed:envie_m4	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed:envie_m7	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed_nano:nanorp2040connect	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkr1000	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0
arduino:samd:mkrgsm1400	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0
arduino:samd:mkrnb1500	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0
arduino:samd:mkrwan1300	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrwifi1010	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:nano_33_iot	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	0	0.0	0	0.0
esp32:esp32:esp32	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
esp8266:esp8266:huzzah	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,