Skip to content

Various minor refactor operations #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2020
Merged

Various minor refactor operations #141

merged 3 commits into from
Jun 10, 2020

Conversation

aentinger
Copy link
Contributor

No description provided.

@aentinger aentinger added the type: enhancement Proposed improvement label Jun 10, 2020
@aentinger aentinger self-assigned this Jun 10, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020

Codecov Report

Merging #141 into master will decrease coverage by 0.08%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   95.57%   95.49%   -0.09%     
==========================================
  Files          29       29              
  Lines         995      998       +3     
==========================================
+ Hits          951      953       +2     
- Misses         44       45       +1     
Impacted Files Coverage Δ
src/cbor/ArduinoCloudThing.h 100.00% <ø> (ø)
src/property/PropertyContainer.cpp 90.76% <94.11%> (+1.18%) ⬆️
src/cbor/ArduinoCloudThing.cpp 95.85% <100.00%> (-0.23%) ⬇️
src/property/Property.cpp 86.16% <100.00%> (ø)
src/property/Property.h 90.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd6901d...4d74549. Read the comment docs.

@github-actions
Copy link

Memory usage change @4d74549a9f0986606c7a7fc9d8b3de3becf61c90

FQBN Flash Usage RAM For Global Variables
arduino:samd:mkr1000 🔺 +32 0
arduino:samd:mkrgsm1400 🔺 +32 0
arduino:samd:mkrnb1500 🔺 +32 0
arduino:samd:mkrwan1300 🔺 +32 0
arduino:samd:mkrwifi1010 🔺 +32 0
arduino:samd:nano_33_iot 🔺 +40 0
esp8266:esp8266:huzzah 🔺 +48 0

@aentinger
Copy link
Contributor Author

Successfully tested on PROD with:

  • MKR 1000 ✔️

@aentinger aentinger merged commit 51981c1 into master Jun 10, 2020
@aentinger aentinger deleted the refactor-1 branch June 10, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants