Refactoring ArduinoIoTCloud #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce 'delete' can handle a NULL value
…nt has been assigned a valid value - it should have the NULL value assigned at object construction
…in method to dedicated util class CryptoUtil for better readability
…uctCertificate' which allows for a similiar check/control flow in 'ArduinoIoTCloud::begin'
…only needed there
…f a C++ header/source file
…ther understanding)
…loudTCP' since its not needed for LoRa boards
…irtual functions within the ArduinoIoTCloud base class There is no need for this since the communication mechanism is different for TCP enabled and LoRa based boards. Removing of both writeStdout and writeShadowOut since they are not required for LoRa boards (there isn't even MQTT in play)
…hem to be protected
…lementation within this class
…ClientBegin to begin which makes puts the change closer to where it actually matters
…method since they share most of the code except for a topic parameter which is an additional parameter to the new function 'write'
…TCP' since its not needed for 'ArduinoIoTCloudLPWAN'
…s not needed for 'ArduinoIoTCloudLPWAN'
…with member variable naming
…d for the function to be public
… needed outside of it
…nt since there is no need for the constant to be public
…tion to the LoRa gateway
…te handling code analog to the TCP version
…erver like the TCP based boards do. Instead we only have a connection to the gateway and no control wether or not this connection extends to cloud. Therefore checking the connection to the gateway is the only thing we can do.
…cur on the board (e.g. connecting -> connected)
…an't know if there really is a connection to the cloud since this is conceptually impossible if we have only a connection to the gateway
… across all files
|
Successfully tested on PROD with
|
…er part of the ArduinoIoTCloud library
|
@Rocketct can you please test this PR with |
|
@aentinger yes 'l ask to our colleague in Malmo and report as as soon as we will get some results |
|
@aentinger our colleague test it and works properly, he test the things creation and data exchange between cloud and NB ad all works fine |
|
@Rocketct Thank you very much 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the course of the
ArduinoIoTClouddevelopment a lot of clutter has gathered which makes it more difficult to use the existing code base to add something new on top (technical debt). This PR is touching many areas of the code but still tries to keep atomic commits as much as possible.