Add (optional) company ID argument to BLE.setManufacturerData(....) #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
requested changes
Sep 3, 2019
fix format Co-Authored-By: per1234 <[email protected]>
fix format Co-Authored-By: per1234 <[email protected]>
Co-Authored-By: per1234 <[email protected]>
There was a problem hiding this comment.
Hi @konikoni428,
Thanks for submitting this pull request!
It looks fine, but it would be great it we could have both versions of the API for backwards compatibility.
| @@ -43,7 +43,7 @@ class BLELocalDevice { | |||
|
|
|||
| void setAdvertisedServiceUuid(const char* advertisedServiceUuid); | |||
| void setAdvertisedService(const BLEService& service); | |||
| void setManufacturerData(const uint8_t manufacturerData[], int manufacturerDataLength); | |||
| void setManufacturerData(const uint16_t companyId, const uint8_t manufacturerData[], int manufacturerDataLength); | |||
There was a problem hiding this comment.
It would be good to maintain backwards compatibility here and support both the newer and older API.
There was a problem hiding this comment.
Thank you for pointing out the problem.
Please check new code.
sandeepmistry
approved these changes
Sep 5, 2019
There was a problem hiding this comment.
@konikoni428 thanks for updating, the latest changes look good!
sandeepmistry
changed the title
|
@SimonePDA we'll have to update the following page accordingly: https://www.arduino.cc/en/Reference/ArduinoBLEBLEsetManufacturerData There's a new syntax to be added:
|
cparata
added a commit
to cparata/ArduinoBLE
that referenced
this pull request
Sep 30, 2020
Add support to X-NUCLEO-IDB05A2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
ArduinoBLE referense sample code
Result of code execution
0x0201 -> companyId
0x03, 0x04, 0x05 -> manufacturerData
I think it ’s very confusing.
change
BLE.setManufacturerData(uint8_ uint8_t manufacturerData[], int manufacturerDataLength)
↓
BLE.setManufacturerData(const uint16_t companyId, const uint8_t manufacturerData[], int manufacturerDataLength)
use
0x1234 -> companyId
0x01, 0x02, 0x03, 0x04, 0x05 -> manufacturerData