Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

Restore JavaScript highlighting #1046

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Restore JavaScript highlighting #1046

merged 1 commit into from
Jun 27, 2022

Conversation

Simran-B
Copy link
Collaborator

@Simran-B Simran-B commented Jun 27, 2022

#1032 accidentally changed how AQL is colorized using the JavaScript highlighter (3.9 and earlier). Too many tokens are blue, e.g.

image

https://deploy-preview-1032--zealous-morse-14392b.netlify.app/docs/3.9/aql/tutorial-crud.html#update-documents

  • Remove definition of Name.Builtin and Name.Other (only used by JS highlighter) to use the default color again
  • Fix Name.Builtin.Pseudo class name to properly apply the style to AQL colorized with the AQL highlighter

Reverted:

image

https://deploy-preview-1046--zealous-morse-14392b.netlify.app/docs/3.9/aql/tutorial-crud.html#update-documents

Remove definition of Name.Builtin and Name.Other (only used by JS highlighter) to use the default color again. Fix Name.Builtin.Pseudo class name.
@Simran-B Simran-B assigned Simran-B and ansoboleva and unassigned ansoboleva Jun 27, 2022
@Simran-B Simran-B requested a review from ansoboleva June 27, 2022 14:25
@Simran-B Simran-B added this to the 3.9 milestone Jun 27, 2022
@ansoboleva ansoboleva merged commit 0596536 into main Jun 27, 2022
@ansoboleva ansoboleva deleted the aql-lexer-fix branch June 27, 2022 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants