Improve query logging #17388
Merged
Improve query logging #17388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2022
Merged
Merged
|
@cta-bot check |
mpoeter
approved these changes
Oct 20, 2022
| if (!_resultCode.has_value()) { | ||
| ensureExecutionTime(); | ||
|
|
||
| if (!_resultCode.has_value()) { // TODO possible data race here |
There was a problem hiding this comment.
What about this TODO? Should we address it here? If not, do we have a ticket?
Simran-B
reviewed
Oct 27, 2022
| @@ -400,6 +403,46 @@ void QueryRegistryFeature::collectOptions( | |||
| arangodb::options::makeDefaultFlags(arangodb::options::Flags::Hidden)) | |||
| .setIntroducedIn(30800) | |||
| .setDeprecatedIn(30900); | |||
|
|
|||
| options | |||
| ->addOption("--query.max-artifact-log-length", | |||
There was a problem hiding this comment.
Can it be set to 0 to (more or less) allow any length?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Backport of #17300
Docs PR: arangodb/docs#1140
--query.log-failedto optionally log all failed AQL queries to the server log. The option is turned off by default, by can be turned on for development or debugging.--query.log-memory-usage-thresholdto optionally log all AQL queries that have a peak memory usage larger than the configured value.--query.max-artifact-log-lengthto control the cutoff length for logged query strings and bind parameter values. This allows truncating large query strings and bind parameter values to reasonable lengths. Previously the cutoff value was hard-coded.Checklist
Related Information