Skip to content

[DE-81] Feature/unicode db name #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jan 11, 2022
Merged

[DE-81] Feature/unicode db name #405

merged 22 commits into from
Jan 11, 2022

Conversation

rashtao
Copy link
Collaborator

@rashtao rashtao commented Aug 31, 2021

Database names are now represented in API parameters by the wrapper class com.arangodb.DbName.
It allows for early detecting non-NFC-normalized unicode names either throwing an error or normalizing them. DbName can be instantiated in the following ways:

  • DbName.of(String): throws an IllegalArgumentException in case the input is not NFC-normalized
  • DbName.normalize(String): NFC-normalizes the input and instantiates a DbName with the transformed value.

Once instantiated, DbName.get() returns the wrapped value String, which is always NFC-normalized (as required by ArangoDB extended naming convention).

Every public API accepting database names as String has been deprecated for removal.

@rashtao rashtao marked this pull request as ready for review September 17, 2021 12:19
# Conflicts:
#	.github/workflows/maven.yml
#	ChangeLog.md
#	docker/start_db_active-failover.sh
#	docker/start_db_cluster.sh
#	docker/start_db_single.sh
@rashtao rashtao changed the title Feature/unicode db name [DE-81] Feature/unicode db name Nov 19, 2021
@cla-bot cla-bot bot added the cla-signed label Jan 11, 2022
@rashtao rashtao merged commit 4d39da8 into master Jan 11, 2022
@rashtao rashtao deleted the feature/unicode_db_name branch July 19, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant