Skip to content

feat(List Groups): Migrate List Groups FAB to React #33301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat(List Groups): Migrate List Groups FAB to React #33301

wants to merge 2 commits into from

Conversation

EnxDev
Copy link
Contributor

@EnxDev EnxDev commented Apr 30, 2025 •
edited
Loading

SUMMARY 🚀

This PR migrates the Group List view from server-side rendering (SSR) to fully client-side rendering using React ⚛️.
In addition, it introduces a groups input and filtering functionality for ListUsers and ListRoles views ✨

Changes Included 🔧

  • Migrated the Group List View from FAB to a React-based implementation ⚛️
  • Added groups input and filtering capabilities for ListUsers and ListRoles views 🔍
  • Reused existing API endpoints for seamless integration 🔁
  • Maintained feature parity with the previous implementation ✅
  • Updated routing and navigation accordingly 🧭

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  • before
    before1

  • after
    after-1

  • before
    before-2

  • after
    after-2

TESTING INSTRUCTIONS

  1. Run superset init
  2. Go to the settings on the menu and click Groups

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@EnxDev
feat(groups):
3cb1ded 
- added GroupModals component
- implemented full CRUD handling for groups
- added GroupList to the frontend
- included unittests for list groups view
@korbit-ai Korbit AI
Copy link

korbit-ai bot commented Apr 30, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@github-actions github-actions bot added the api Related to the REST API label Apr 30, 2025
@EnxDev EnxDev mentioned this pull request Apr 30, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api Related to the REST API frontend:refactor:antd5 frontend:refactor Related to refactoring the frontend review:draft size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EnxDev