Properly handle table existence check for jdbc dialects #50835
+120
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR, I propose that we rethrow exception when we are doing table existence check in jdbc dialect, if exception is not related to table not being found. I propose this because currently all exceptions get swallowed and method returns false. From the perspective of the system its as if table doesn't exist, which is a wrong message (e.g, we can get table does not exist if network to jdbc database is down).
This issue is mostly exposed when TableCatalog API is used,
How its implemented today, tableExist cannot throw anything, so every exception gets converted to noSuchTableError which is wrong.
Does this PR introduce any user-facing change?
Customers will get proper error messages.
How was this patch tested?
Tests
Was this patch authored or co-authored using generative AI tooling?
Generetad by: COPILOT