[SPARK-51972][SS] State Store file integrity verification using checksum #50773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anishshri-db
reviewed
May 1, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
Outdated
Show resolved
Hide resolved
anishshri-db
reviewed
May 1, 2025
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala
Outdated
Show resolved
Hide resolved
anishshri-db
reviewed
May 2, 2025
.../src/main/scala/org/apache/spark/sql/execution/streaming/ChecksumCheckpointFileManager.scala
Outdated
Show resolved
Hide resolved
anishshri-db
reviewed
May 2, 2025
.../src/main/scala/org/apache/spark/sql/execution/streaming/ChecksumCheckpointFileManager.scala
Outdated
Show resolved
Hide resolved
anishshri-db
reviewed
May 2, 2025
.../src/main/scala/org/apache/spark/sql/execution/streaming/ChecksumCheckpointFileManager.scala
Show resolved
Hide resolved
anishshri-db
reviewed
May 2, 2025
.../src/main/scala/org/apache/spark/sql/execution/streaming/ChecksumCheckpointFileManager.scala
Show resolved
Hide resolved
anishshri-db
reviewed
May 2, 2025
.../src/main/scala/org/apache/spark/sql/execution/streaming/ChecksumCheckpointFileManager.scala
Outdated
Show resolved
Hide resolved
anishshri-db
reviewed
May 2, 2025
.../src/main/scala/org/apache/spark/sql/execution/streaming/ChecksumCheckpointFileManager.scala
Outdated
Show resolved
Hide resolved
anishshri-db
reviewed
May 2, 2025
...apache/spark/sql/execution/datasources/v2/state/StateDataSourceTransformWithStateSuite.scala
Show resolved
Hide resolved
anishshri-db
reviewed
May 2, 2025
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala
Show resolved
Hide resolved
anishshri-db
reviewed
May 2, 2025
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala
Outdated
Show resolved
Hide resolved
anishshri-db
reviewed
May 2, 2025
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala
Show resolved
Hide resolved
anishshri-db
approved these changes
May 6, 2025
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala
Show resolved
Hide resolved
...test/scala/org/apache/spark/sql/execution/streaming/ChecksumCheckpointFileManagerSuite.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introducing file integrity verification for state store files by also generating and uploading checksum file. This allows us to verify the file checksum during read. Introduced a new spark conf to enable/disable this (enabled by default). This can be enabled then disabled and vice versa, on the same checkpoint location, giving users the flexibility to turn on/off as needed.
This implementation is completely backward compatible, it can be enabled on an existing query/checkpoint, and can be disabled later on without breaking the query/checkpoint.
It is currently used for the following state files: delta, snapshot, changelog, zip. We can later enable this for other checkpoint files too e.g. operator metadata files, commit/offset log etc.
Why are the changes needed?
Integrity verification to detect file corruption and provide necessary additional information.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added additional tests
Was this patch authored or co-authored using generative AI tooling?
No