[WIP][SPARK-52011][SQL] Reduce HDFS NameNode RPC on vectorized Parquet reader #50765
+131
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
commented
Apr 30, 2025
| ParquetFileReader fileReader; | ||
| if (fileFooter.isDefined()) { | ||
| fileReader = new ParquetFileReader(configuration, file, fileFooter.get()); |
There was a problem hiding this comment.
This constructor internally calls HadoopInputFile.fromPath(file, configuration), which produces an unnecessary GetFileInfo RPC
public static HadoopInputFile fromPath(Path path, Configuration conf) throws IOException {
FileSystem fs = path.getFileSystem(conf);
return new HadoopInputFile(fs, fs.getFileStatus(path), conf);
}
pan3793
changed the title
|
also cc @turboFei |
pan3793
commented
May 6, 2025
| val footerFilter = ParquetFooterReader.footerFilter( | ||
| sharedConf, file, ParquetFooterReader.WITH_ROW_GROUPS) | ||
| val footer = ParquetFooterReader.readFooter( | ||
| hadoopInputFile, fileInputStream, footerFilter) |
There was a problem hiding this comment.
TODO: close the reader but keep the fileInputStream open, waiting for apache/parquet-java#3208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
On a busy Hadoop cluster, the
GetFileInfoandGetBlockLocationscontribute the most RPCs to the HDFS NameNode. After investigating the Spark Parquet vectorized reader, I think 3/4 RPCs can be reduced.Currently, the Parquet vectorized reader produces 4 NameNode RPCs on reading each file (or split):
GetFileInfoand oneGetBlockLocationsGetFileInfoand oneGetBlockLocationsThe key idea of this PR is:
FileStatusfor each Parquet file during the planning phase, we can transfer theFileStatusfrom the driver to the executor viaPartitionFile, so that the task doesn't need to ask the NameNode again, this saves twoGetFileInfoRPCs.SeekableInputStreamon reading footer and row groups, this saves oneGetBlockLocationsRPC.TODO: The PR currently requires some changes on Parquet side first.
Why are the changes needed?
Reduce unnecessary RPCs of NameNode to improve performance and stability for large Hadoop clusters.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually tested on a Hadoop cluster, the test uses TPC-H Q4, based on sf3000 Parquet tables.
HDFS NameNode metrics (master VS. this PR)
HDFS NameNode audit logs:
Taking file
part-01027-419c80f3-8921-4ed3-b31a-0fe72b9c6732-c000.zstd.parquetas example, the file is supposed to be split into 3 splitsBefore
After
Was this patch authored or co-authored using generative AI tooling?
No.