KAFKA-17747: [3/N] Get rid of TopicMetadata in SubscribedTopicDescriberImpl #19611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
changed the title
dajac
reviewed
May 9, 2025
There was a problem hiding this comment.
@FrankYang0529 Thanks for the patch! I have started to look into it and I left a few high level comments to start with. Out of curiosity, have you tried to run the benchmarks before and after the change to see the impact?
| @@ -3652,11 +3652,11 @@ private Assignment updateTargetAssignment( | |||
| new TargetAssignmentBuilder.ConsumerTargetAssignmentBuilder(group.groupId(), groupEpoch, consumerGroupAssignors.get(preferredServerAssignor)) | |||
| .withMembers(group.members()) | |||
| .withStaticMembers(group.staticMembers()) | |||
| .withSubscriptionMetadata(subscriptionMetadata) | |||
| .withSubscriptionTopicIdSet(subscriptionMetadata.values().stream().map(TopicMetadata::id).collect(Collectors.toSet())) | |||
There was a problem hiding this comment.
I think that our goal is to get rid of subscriptionMetadata so it is a bit surprising to still rely on it here. Could we avoid it?
| * @return The set of topic Ids. | ||
| */ | ||
| public Set<Uuid> subscriptionTopicIdSet() { | ||
| return this.subscriptionTopicIdSet; |
There was a problem hiding this comment.
Given how this is used (mainly in tests), I think that we should rather try to remove it. Would it be possible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
TopicMetadatawithsubscriptionTopicIdSetandMetadataImageinSubscribedTopicDescriberImplandTargetAssignmentBuilder.