Skip to content

chore: remove XFAIL from passing tests #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2024
Merged

chore: remove XFAIL from passing tests #884

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c762e06
remove xfail from passing tests
Michael-J-Ward Sep 26, 2024
7578e4b
update xfail cmoment for datetime_s
Michael-J-Ward Sep 26, 2024
587e94e
document upstream issue for timestamp[s] xfail test
Michael-J-Ward Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions python/datafusion/tests/test_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,23 +378,29 @@ def test_udf(
helpers.data_binary_other(),
helpers.data_date32(),
helpers.data_with_nans(),
# C data interface missing
pytest.param(
pa.array([b"1111", b"2222", b"3333"], pa.binary(4), _null_mask),
id="binary4",
marks=pytest.mark.xfail,
),
# `timestamp[s]` does not roundtrip for pyarrow.parquet: https://github.com/apache/arrow/issues/41382
pytest.param(
helpers.data_datetime("s"), id="datetime_s", marks=pytest.mark.xfail
helpers.data_datetime("s"),
id="datetime_s",
marks=pytest.mark.xfail(
reason="pyarrow.parquet does not support timestamp[s] roundtrips"
),
),
pytest.param(
helpers.data_datetime("ms"), id="datetime_ms", marks=pytest.mark.xfail
helpers.data_datetime("ms"),
id="datetime_ms",
),
pytest.param(
helpers.data_datetime("us"), id="datetime_us", marks=pytest.mark.xfail
helpers.data_datetime("us"),
id="datetime_us",
),
pytest.param(
helpers.data_datetime("ns"), id="datetime_ns", marks=pytest.mark.xfail
helpers.data_datetime("ns"),
id="datetime_ns",
),
# Not writtable to parquet
pytest.param(
Expand Down
Loading