Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

feat(@angular-devkit/build-optimizer): support webpack side effects flag #531

Merged
merged 1 commit into from
Mar 19, 2018
Merged

feat(@angular-devkit/build-optimizer): support webpack side effects flag #531

merged 1 commit into from
Mar 19, 2018

Conversation

clydin
Copy link
Member

@clydin clydin commented Mar 19, 2018

No description provided.

@clydin clydin requested a review from filipesilva March 19, 2018 16:21
@clydin clydin mentioned this pull request Mar 19, 2018
Closed
filipesilva
filipesilva suggested changes Mar 19, 2018
View reviewed changes
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to either add a defensive option here, or completely move the peer dep to Webpack 4 and remove the path regexes. The second option also makes it only work for Angular 6+ though.

@clydin
Copy link
Member Author

clydin commented Mar 19, 2018 •
edited
Loading

Updated to now work on older versions of webpack and fallback to the whitelist.

@filipesilva filipesilva merged commit 5d0129a into angular:master Mar 19, 2018
@clydin clydin deleted the side-effects branch March 19, 2018 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesilva filipesilva filipesilva approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clydin @filipesilva @googlebot