Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(directive): Adding documentation and example of using a templateUrl function to the directive developer guide. #9580

Closed
wants to merge 3 commits into from

Conversation

spaceribs
Copy link
Contributor

Adding documentation and example of using a templateUrl function to the directive developer guide.

Related to #2895

Adding documentation and example of using a templateUrl function to the directive developer guide.

Related to angular#2895
# By Peter Bacon Darwin (3) and others
# Via Peter Bacon Darwin
* 'master' of https://github.com/angular/angular.js:
  chore(docs): apply the anchorScroll offset feature to the docs app
  feat($anchorScroll): support a configurable vertical scroll offset
  feat(jqLite): add private jqDocumentComplete function
  Added caveat to attr() function of jqLite
  feat(currencyFilter): add fractionSize as optional parameter
  fix($http): allow empty json response
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@spaceribs
Copy link
Contributor Author

Just signed it, thanks!

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@IgorMinar
Copy link
Contributor

@btford can you review this and specifically check if the location of this segment makes sense?

@btford
Copy link
Contributor

btford commented Oct 13, 2014

will do

On Mon, Oct 13, 2014 at 12:03 PM, Igor Minar [email protected]
wrote:

@btford https://github.com/btford can you review this and specifically
check if the location of this segment makes sense?


Reply to this email directly or view it on GitHub
#9580 (comment).

@btford
Copy link
Contributor

btford commented Oct 13, 2014

Made some changes and landed as f277c56. Thanks!

@btford btford closed this Oct 13, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants