This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(ci): really fix code/docs deployment #17066
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `DIST_TAG` environment variable was failing to be computed correctly, because it was using the non-existent `jq` tool. In the past (when running on TravisCI), `jq` used to be available, but it is not on the currently used CircleCI docker image, resulting in the following error: ```sh ./.circleci/env.sh: line 59: jq: command not found DIST_TAG= ``` You can see an example failure in the "Set up environment" step logs in https://app.circleci.com/pipelines/github/angular/angular.js/ 166/workflows/34c692ec-18d4-4422-a1cf-108a91219fa5/jobs/1742 This commit fixes it by using `node` (which _is_ available on the docker image) to compute `$DIST_TAG`.
Previously, the command used to deploy the docs to Firebase (as part of the `deploy-docs` CI job) would fail, because no target project was specified (either directly in the command or indirectly via a `.firebaserc` file in the working directory). Example failure: https://app.circleci.com/pipelines/github/angular/angular.js/ 166/workflows/34c692ec-18d4-4422-a1cf-108a91219fa5/jobs/1744 This commit fixes the command by specifying the project via the `--project` cli argument. It also adds the commit SHA as message to make it easier to associate a deployment with the corresponding commit.
4 tasks
mgol
reviewed
Aug 22, 2020
.circleci/env.sh
Outdated
|
|
||
| #################################################################################################### | ||
| #################################################################################################### | ||
| ## Source `$BASH_ENV` to make the variables available immediately. ## | ||
| ## ***NOTE: This must remain the the last action in this script*** ## | ||
| ## ***NOTE: This must remain the last action in this script.*** ## |
There was a problem hiding this comment.
It’s not aligned with the line above anymore.
There was a problem hiding this comment.
It is center-aligned(-ish) 😁
petebacondarwin
approved these changes
Aug 22, 2020
gkalpak
added a commit
that referenced
this pull request
Aug 22, 2020
Previously, the command used to deploy the docs to Firebase (as part of the `deploy-docs` CI job) would fail, because no target project was specified (either directly in the command or indirectly via a `.firebaserc` file in the working directory). Example failure: https://app.circleci.com/pipelines/github/angular/angular.js/ 166/workflows/34c692ec-18d4-4422-a1cf-108a91219fa5/jobs/1744 This commit fixes the command by specifying the project via the `--project` cli argument. It also adds the commit SHA as message to make it easier to associate a deployment with the corresponding commit. Closes #17066
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues related to code/docs deployment:
DIST_TAGenvironment variable (which is needed in thedeploy-codeCI job).deploy-docsCI job).See individual commits for details.