Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(misc/Version Support Status): adding LTS extension support #17057

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

ewaDev
Copy link
Contributor

@ewaDev ewaDev commented Jul 28, 2020

(): adding extension support information

On twitter, the angular account (https://twitter.com/angular/status/1287780634572857357) has
announced an extension to the Long Term Support period. Updating the website to let people know.

AngularJS is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.

Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new #browser version?

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ewaDev
Copy link
Contributor Author

ewaDev commented Jul 28, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ewaDev ewaDev changed the title docs(misc/Version Support Status): Adding extension of 6months news d… docs(misc/Version Support Status): Adding extension support Jul 28, 2020
@gkalpak gkalpak mentioned this pull request Jul 28, 2020
4 tasks
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is failing due to 2 issues with the commit message:

Invalid commit message, please fix:

- Commit message line 3 too long: 200 characters, only 100 allowed.
Was: On twitter, the angu[...]
- <subject> must start with a lowercase letter

Commit message was:

docs(misc/Version Support Status): Adding extension of 6months news due to covid

On twitter, the angular account on twitter (https://twitter.com/angular/status/1287780634572857357) has announced an extension to the Long Term Support period. Updating the website to let people know.

@ewaDev
Copy link
Contributor Author

ewaDev commented Jul 28, 2020

@Splaktar Thanks for the comments - i have updated commit message. How can I re-run the CircleCI test?

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @ewaDev

I would suggest mentioning "LTS" in the commit message header (to make it easier to know what extension it refers to without having to look at the commit message body or code changes). Something like:

docs(misc/Version Support Status): mention LTS extension by 6 months due to COVID

Due to COVID-19 affecting teams migrating from AngularJS, the Long Term Support period has been
extended by 6 months (until the end of 2021). See announcement on Twitter:
https://twitter.com/angular/status/1287780634572857357

This commit updates the "Version Support Status" page to also mention the extension.

@ewaDev ewaDev changed the title docs(misc/Version Support Status): Adding extension support docs(misc/Version Support Status): adding LTS extension support Jul 28, 2020
@Splaktar
Copy link
Contributor

i have updated commit message. How can I re-run the CircleCI test?

Once you force push your changes up to the patch-1 branch in your fork, CI will run automatically. Though since you appear to be using the GitHub UI, that may be non-trivial. Plus it looks like @gkalpak is handling it for you 😄

@g-patel
Copy link

g-patel commented Jul 28, 2020

Should there be a set date e.g Dec 31, 2021 for the ultimate LTS as opposed to opaque end of 2021.
(like how originally the date was prices, i.e. June 30, 2021)

@g-patel
Copy link

g-patel commented Jul 28, 2020

Thanks @ewaDev for issuing the MR. 👏

@ewaDev ewaDev requested a review from gkalpak July 28, 2020 20:00
@ewaDev
Copy link
Contributor Author

ewaDev commented Jul 28, 2020

I am having issues understanding why my CircleCI: lint is failing. I would really appreciate if someone would help me with sorting this out, thank you!

…due to COVID

Due to COVID-19 affecting teams migrating from AngularJS, the Long Term Support period has been
extended by 6 months (until the end of 2021). See announcement on Twitter:
https://twitter.com/angular/status/1287780634572857357

This commit updates the "Version Support Status" page to also mention the extension.

Partially addresses angular#17058.
@gkalpak
Copy link
Member

gkalpak commented Jul 28, 2020

The linting was failing because some of the commit messages did not adhere to our guidelines. More specifically, some lines were longer than the max allowed 100 chars.

I have made some changes to the PR:

@ewaDev, please take a look and lmk if it looks good to you. Thanks again for kicking this off 👍

@ewaDev
Copy link
Contributor Author

ewaDev commented Jul 28, 2020

Looks great @gkalpak ! Thanks for squashing the commits, I did not realise all of the commits had to comply. Thanks !

@g-patel
Copy link

g-patel commented Jul 29, 2020

@gkalpak I am curious, are we waiting on some before merging the PR?

@gkalpak
Copy link
Member

gkalpak commented Jul 30, 2020

I @g-patel, I wanted to give people time to offer feedback and check with DevRel. Merging now...

@gkalpak gkalpak merged commit 6617ed5 into angular:v1.8.x Jul 30, 2020
@ewaDev ewaDev deleted the patch-1 branch July 30, 2020 09:46
@ewaDev
Copy link
Contributor Author

ewaDev commented Jul 30, 2020

I am not seeing this change in the docs online. I am wondering if there is something else we should be doing?

@g-patel
Copy link

g-patel commented Jul 30, 2020

I am not seeing this change in the docs online. I am wondering if there is something else we should be doing?

Plus 1

@g-patel
Copy link

g-patel commented Jul 30, 2020

I @g-patel, I wanted to give people time to offer feedback and check with DevRel. Merging now...

@gkalpak Thanks much for the update.

@gkalpak
Copy link
Member

gkalpak commented Jul 30, 2020

It has been deployed to the latest snapshot, but not to other versions. You can see it live here (or by selecting master-snapshot in the version picker).

Our docs deployment infrastructure seems to nave been slightly broken since we switched from TravisCI to CircleCI. I will look fixing it and/or manually deploying.

@gkalpak
Copy link
Member

gkalpak commented Aug 3, 2020

FYI, I am working on a fix in #17060 (if anyone wants to follow my progress).

@g-patel
Copy link

g-patel commented Aug 4, 2020

FYI, I am working on a fix in #17060 (if anyone wants to follow my progress).

@gkalpak Thanks for providing the update.

@ewaDev
Copy link
Contributor Author

ewaDev commented Aug 6, 2020

@gkalpak thanks for looking into this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants