-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs(misc/Version Support Status): adding LTS extension support #17057
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI is failing due to 2 issues with the commit message:
Invalid commit message, please fix:
- Commit message line 3 too long: 200 characters, only 100 allowed.
Was: On twitter, the angu[...]
- <subject> must start with a lowercase letter
Commit message was:
docs(misc/Version Support Status): Adding extension of 6months news due to covid
On twitter, the angular account on twitter (https://twitter.com/angular/status/1287780634572857357) has announced an extension to the Long Term Support period. Updating the website to let people know.
@Splaktar Thanks for the comments - i have updated commit message. How can I re-run the CircleCI test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, @ewaDev ✨
I would suggest mentioning "LTS" in the commit message header (to make it easier to know what extension it refers to without having to look at the commit message body or code changes). Something like:
docs(misc/Version Support Status): mention LTS extension by 6 months due to COVID
Due to COVID-19 affecting teams migrating from AngularJS, the Long Term Support period has been
extended by 6 months (until the end of 2021). See announcement on Twitter:
https://twitter.com/angular/status/1287780634572857357This commit updates the "Version Support Status" page to also mention the extension.
Once you force push your changes up to the |
Should there be a set date e.g Dec 31, 2021 for the ultimate LTS as opposed to opaque end of 2021. |
Thanks @ewaDev for issuing the MR. 👏 |
I am having issues understanding why my CircleCI: lint is failing. I would really appreciate if someone would help me with sorting this out, thank you! |
…due to COVID Due to COVID-19 affecting teams migrating from AngularJS, the Long Term Support period has been extended by 6 months (until the end of 2021). See announcement on Twitter: https://twitter.com/angular/status/1287780634572857357 This commit updates the "Version Support Status" page to also mention the extension. Partially addresses angular#17058.
The linting was failing because some of the commit messages did not adhere to our guidelines. More specifically, some lines were longer than the max allowed 100 chars. I have made some changes to the PR:
@ewaDev, please take a look and lmk if it looks good to you. Thanks again for kicking this off 👍 |
Looks great @gkalpak ! Thanks for squashing the commits, I did not realise all of the commits had to comply. Thanks ! |
@gkalpak I am curious, are we waiting on some before merging the PR? |
I @g-patel, I wanted to give people time to offer feedback and check with DevRel. Merging now... |
I am not seeing this change in the docs online. I am wondering if there is something else we should be doing? |
Plus 1 |
It has been deployed to the latest snapshot, but not to other versions. You can see it live here (or by selecting Our docs deployment infrastructure seems to nave been slightly broken since we switched from TravisCI to CircleCI. I will look fixing it and/or manually deploying. |
FYI, I am working on a fix in #17060 (if anyone wants to follow my progress). |
@gkalpak thanks for looking into this! |
(): adding extension support information
On twitter, the angular account (https://twitter.com/angular/status/1287780634572857357) has
announced an extension to the Long Term Support period. Updating the website to let people know.
AngularJS is in LTS mode
We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.
Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new #browser version?
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: