-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Conversation
Specify line endings for Windows builds. Closes angular#10431
4153e94
to
7934adb
Compare
This is complement to the previous commit. It also refactors the input compile helpers to make it cleaner and more consistent.
When adding entries to the cache and the `value` is `undefined`, no entry should be added to the `lruHash`
Remove unnecessary 'and' in $compile docs. Closes angular#10582
Renamed the internal function `int` to `toInt` as `int` is a reserved word Closes angular#7768
Fix a typo on an example from the `input` directive
@FarSeeing thnx for the PR, we definitively want to merge this one. But I think that we should add more extensions to the list, at least: css, html, json, md, sh and probably other text file extensions. Would you be up to updating your PR based on the above suggestion? |
No problem. |
@FarSeeing jQuery's approach sounds sensible, we can go down this path. |
-Non-idiomatic use of an expression "from the ground up". -Missing commas. Closes angular#10593
Specify line endings for Windows builds. Closes angular#10431
Specify line endings for Windows builds. Closes angular#10431
Conflicts: .gitattributes
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Specify line endings for Windows builds. Closes angular#10431
Sorry, messed with my git branch. Will close this pull request and open another one. |
Specify line endings for Windows builds.
Closes #10431