Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore: add .gitattributes file #10561

Closed
wants to merge 15 commits into from
Closed

Conversation

FarSeeing
Copy link
Contributor

Specify line endings for Windows builds.

Closes #10431

Specify line endings for Windows builds.

Closes angular#10431
@FarSeeing FarSeeing changed the title Chore: add .gitattributes file chore: add .gitattributes file Dec 23, 2014
petebacondarwin and others added 7 commits December 24, 2014 23:19
This is complement to the previous commit.
It also refactors the input compile helpers to make it cleaner and more
consistent.
When adding entries to the cache and the `value` is `undefined`, no
entry should be added to the `lruHash`
Remove unnecessary 'and' in $compile docs.

Closes angular#10582
Renamed the internal function `int` to `toInt` as `int` is a reserved word

Closes angular#7768
Fix a typo on an example from the `input` directive
@pkozlowski-opensource
Copy link
Member

@FarSeeing thnx for the PR, we definitively want to merge this one. But I think that we should add more extensions to the list, at least: css, html, json, md, sh and probably other text file extensions.

Would you be up to updating your PR based on the above suggestion?

@pkozlowski-opensource pkozlowski-opensource self-assigned this Dec 29, 2014
@pkozlowski-opensource pkozlowski-opensource added this to the 1.3.9 milestone Dec 29, 2014
@FarSeeing
Copy link
Contributor Author

No problem.
Do you want to specify these extensions or to like jQuery does?

@pkozlowski-opensource
Copy link
Member

@FarSeeing jQuery's approach sounds sensible, we can go down this path.

袴田 俊輔 and others added 5 commits December 29, 2014 21:15
-Non-idiomatic use of an expression "from the ground up".
-Missing commas.

Closes angular#10593
Specify line endings for Windows builds.

Closes angular#10431
Specify line endings for Windows builds.

Closes angular#10431
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@FarSeeing
Copy link
Contributor Author

Sorry, messed with my git branch. Will close this pull request and open another one.

@FarSeeing FarSeeing closed this Dec 30, 2014
@FarSeeing FarSeeing deleted the gitattributes branch December 30, 2014 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git repository is missing .gitattributes file
8 participants