Skip to content

feat(@angular/cli): optimize stylesheets after bundling #8764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 21, 2017

Conversation

clydin
Copy link
Member

@clydin clydin commented Dec 6, 2017

Re-structuring the webpack resource loader allows the new stylesheet optimizing plugin to process component styles as well as global styles. Global styles are now optimized as a whole rather than in isolated parts; allowing for more comprehensive optimizations.

Fixes #8598
Fixes #8640 (2nd commit)
Fixes #8934; Fixes #8891 (2nd & 3rd commit)

@clydin clydin force-pushed the cleancss-integ branch 3 times, most recently from 8aa92a7 to d7cd308 Compare December 7, 2017 14:52
@clydin clydin changed the title refactor(@angular/cli): use clean-css to optimize stylesheets feat(@angular/cli): use clean-css to optimize stylesheets Dec 7, 2017
@clydin clydin force-pushed the cleancss-integ branch 3 times, most recently from 3633e02 to d08d2f9 Compare December 8, 2017 18:58
@clydin clydin requested a review from hansl as a code owner December 8, 2017 18:58
@clydin clydin removed the state: WIP label Dec 8, 2017
@clydin clydin force-pushed the cleancss-integ branch 14 times, most recently from a5487ec to 138b697 Compare December 14, 2017 03:22
@clydin clydin changed the title feat(@angular/cli): use clean-css to optimize stylesheets feat(@angular/cli): optimize stylesheets after bundling Dec 14, 2017
@clydin clydin requested a review from filipesilva December 14, 2017 03:23
filipesilva
filipesilva previously approved these changes Dec 14, 2017
@filipesilva filipesilva merged commit 64b4b03 into angular:master Dec 21, 2017
@clydin clydin deleted the cleancss-integ branch December 21, 2017 13:12
@rokerkony
Copy link

Hi guys,
after upgrade to CLI v1.6.3 (angular in v5.1.2) and removing node_modules and lock file I still have an error with Node#moveTo was deprecated. Use Container#append.

It seems that #8598 is not fixed yet :(

@clydin @filipesilva

@devoto13
Copy link
Contributor

@rokerkony This PR is marked as feat, which means that it will be available only in CLI 1.7, not in patch releases of 1.6.

@rokerkony
Copy link

@devoto13 oh, I saw it in the release notes:
https://github.com/angular/angular-cli/releases

if it is as you say, I'll wait for that, thank you

@denny89k
Copy link

@devoto13 @rokerkony could i use some angular/cli version with angular 5 without this issue?

@devoto13
Copy link
Contributor

@DzianisUkrainets you can try 1.7.0-beta.2.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants