Skip to content

fix(@schematics/angular): drop composite in tsconfig #30125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

cexbrayat
Copy link
Member

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Based on this TS discussion, composite is in fact not necessary, the TS docs are just misleading.

What is the new behavior?

This removes composite from the configs, as it was recently done in create-vue (see vuejs/create-vue#635).

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Based on this [TS discussion](microsoft/TypeScript#60465), `composite` is in fact not necessary, the TS docs are just misleading.
@clydin clydin added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Apr 18, 2025
@clydin clydin merged commit 672ae14 into angular:main Apr 18, 2025
33 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants