Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Feature minimum input length #336

Closed
wants to merge 3 commits into from

Conversation

jiverson
Copy link

Added in minimum input length with tests from #326 and removed locale.

@simkessy
Copy link

I can't get this to work? How do you implement it?

@sonicdoe
Copy link

@simkessy I had problems trying it out, too. For example, I don’t see where ctrl.noResultsMessage gets called. I think some changes got lost from @iamWh1sp3r’s original pull request.

As I needed this feature recently I decided to clean up the code and implement it myself. Feel free to give it a try on the demo page. I plan to add more tests in the next couple of days and submit a pull request myself. Let me know if it works for you.

@simkessy
Copy link

@SonicHedgehog change the cdn references protocol from "http" to "//" or the demo page breaks. Otherwise it looks good. Hopefully it get's pulled soon.

@sonicdoe
Copy link

@simkessy I don’t intend to keep that demo page running but good point, though. I have fixed it, for now.

@igorlino
Copy link

+1

@user378230
Copy link
Contributor

Closing as #1291 has been merged.

@user378230 user378230 closed this Mar 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants