This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix-#1499-error #1514
Closed
fix-#1499-error #1514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix-angular-ui#1499-error
|
when to merge pull request? |
|
Hi, please see commit guidelines in contributing doc. If you can clean up the commit I will merge. Note that the comment |
|
This may supercede #170. |
clear up comment //fix-angular-ui#1499-error.
|
This also needs a test, it probably got through because one currently doesn't exist for attribute usage of the directive. |
|
Closing as superseded by #1555 as per #1580 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix-#1499-error