Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Click on selector icon does not open droppown #1862

Closed
DioNNiS opened this issue Dec 3, 2016 · 8 comments
Closed

Click on selector icon does not open droppown #1862

DioNNiS opened this issue Dec 3, 2016 · 8 comments

Comments

@DioNNiS
Copy link

DioNNiS commented Dec 3, 2016

Bug description:

Issue appears on the lastest version of the component ("ui-select": "0.19.6").
Issue reproduced only if bootstrap theme is used and search edit box is disabled.

Link to minimally-working plunker that reproduces the issue:

Try official example: http://angular-ui.github.io/ui-select/demo-disable-search.html

@Jefiozie
Copy link
Contributor

Jefiozie commented Dec 3, 2016

Hi @DioNNiS , tested this in chrome look like it is working. Maybe i'm using the wrong browser?

@SparksFyz
Copy link

SparksFyz commented Dec 5, 2016

related to #1797

@DioNNiS
Copy link
Author

DioNNiS commented Dec 5, 2016

@Jefiozie issue reproduced on Mac
Chrome 54.0.2840.98
Firefox 50.0.2

Looks like issue really related to #1797

@dsisoev
Copy link

dsisoev commented Mar 1, 2017

Hi guys,
I think that this issue related with:

  // Toggle dropdown
  ctrl.toggle = function(e) {
    if (ctrl.open) {
      ctrl.close();
      e.preventDefault();
      e.stopPropagation();
    } else {
      ctrl.activate();
    }
  };

I just changed it to:

  // Toggle dropdown
  ctrl.toggle = function(e) {
    if (ctrl.open) {
      ctrl.close();
    } else {
      ctrl.activate();
    }
    e.preventDefault();
    e.stopPropagation();
  };

And all works well.

Thanks.

@Jefiozie
Copy link
Contributor

Jefiozie commented Mar 7, 2017

Maybe one of you guys can have a look and make a PR for it? Maybe @dsisoev ?

@Jefiozie
Copy link
Contributor

Looks like the pr #2011 has fixed the problem. Could you verify?

@amarmechai
Copy link

yes, the pr #2011 fix the problem for me. thanks

@Jefiozie
Copy link
Contributor

Closing down @amarmechai checked if this issue is fixed. If needed it can be reopend.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants