feat(urlMatcherFactory): add support for dot notation in query parameters #1718
Conversation
…ters
Add support for specifying query parameters using object dot notation (i.e. ?foo.bar)
Change $stateParams to mimic object structure defined in dot notated query parameters.
For example, given the state url "/user/?foo.bar" and the url fragment "/user/?foo.bar=baz"
$stateParams will be: { "foo": { "bar": "baz" } }
|
Seems a little out there. Not sure how I feel about it. @christopherthielen? Also, you committed release files. |
|
Sorry, forgot github automatically pulls in commits until the PR is merged. I took out the "release" commit. |
|
I have no problem with supporting dots in param names, but the value being expanded into an object based on the param name feels really odd and unexpected to me. I can't think of the use case that couldn't be solved in other ways. @drgould what kind of params are you doing this with, and why expand the object out? |
|
I mainly need it for namespacing. We expose certain options that can be changed via query params. A few examples: Maybe it could be something separate as to not drastically change the current function of |
Yeah, I feel like maybe a mapping layer that sits between |
|
I took out the object conversion so this can get merged in while I investigate a better way to do the conversion. |
|
This issue has been automatically marked as stale because it has not had This does not mean that the issue is invalid. Valid issues Thank you for your contributions. |
I have a use case for using dot notated query parameters (e.g. ?foo.bar=baz) and I noticed support was lacking from ui-router. As far as I can tell there is nothing that restricts dot notation in urls.
As part of this, it now recreates the implied structure for dot notated parameters. So "?foo.bar=baz" will result in $stateParams being: { "foo": { "bar": "baz" } }