Skip to content

Remove reference to the ember-addon. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kiwiupover
Copy link

Did you mean to leave a reference to the ember-addon

Did you mean to leave a reference to the ember-addon
@JohannesHoppe
Copy link
Member

This was not a mistake.

I assume that you think an angular-cli shouldn’t be part of the ember-ecosystem.
You are not the first person that suggests such a change. Right now there are similar pull requests to the other angular-cli addon, concerning the same:
IgorMinar/angular-cli-github-pages#1
IgorMinar/angular-cli-github-pages#3

Right now angular-cli is based on top of ember-cli.
Technically angular-cli-ghpages is still a 100% compliant ember-addon.
This might change in future. See angular/angular-cli#55

This plugin will run perfectly as a “normal” ember addon, too. It pushes stuff from ./dist (or any other folder) to any gh-pages (or any other branch) to any git repository. It’s valuable for every ember build. But yes, the name indicates a deep relation to Angular 2 builds.

I will keep the pull request open, so that it can be found easily.

@JohannesHoppe
Copy link
Member

Problem solved. This is not any longer a ember-addon.

JohannesHoppe pushed a commit that referenced this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants