Return value of pygad.GA.tournament_selection misleading #89
Assignees
Labels
invalid
This doesn't seem right
Comments
ahmedfgad
added
bug
|
Yes, you are right. There was an issue returning the indices of the selected parents. But still the correct parents are returned because |
ahmedfgad
added a commit
that referenced
this issue
Jul 8, 2022
## PyGAD 2.17.0 Release Date: 8 July 2022 1. An issue is solved when the `gene_space` parameter is given a fixed value. e.g. gene_space=[range(5), 4]. The second gene's value is static (4) which causes an exception. 2. Fixed the issue where the `allow_duplicate_genes` parameter did not work when mutation is disabled (i.e. `mutation_type=None`). This is by checking for duplicates after crossover directly. #39 3. Solve an issue in the `tournament_selection()` method as the indices of the selected parents were incorrect. #89 4. Reuse the fitness values of the previously explored solutions rather than recalculating them. This feature only works if `save_solutions=True`. 5. Parallel processing is supported. This is by the introduction of a new parameter named `parallel_processing` in the constructor of the `pygad.GA` class. Thanks to [@windowshopr](https://github.com/windowshopr) for opening the issue [#78](#78) at GitHub. Check the [Parallel Processing in PyGAD](https://pygad.readthedocs.io/en/latest/README_pygad_ReadTheDocs.html#parallel-processing-in-pygad) section for more information and examples.
ahmedfgad
added a commit
that referenced
this issue
Jul 8, 2022
PyGAD 2.17.0 Release Date: 8 July 2022 1. An issue is solved when the `gene_space` parameter is given a fixed value. e.g. gene_space=[range(5), 4]. The second gene's value is static (4) which causes an exception. 2. Fixed the issue where the `allow_duplicate_genes` parameter did not work when mutation is disabled (i.e. `mutation_type=None`). This is by checking for duplicates after crossover directly. #39 3. Solve an issue in the `tournament_selection()` method as the indices of the selected parents were incorrect. #89 4. Reuse the fitness values of the previously explored solutions rather than recalculating them. This feature only works if `save_solutions=True`. 5. Parallel processing is supported. This is by the introduction of a new parameter named `parallel_processing` in the constructor of the `pygad.GA` class. Thanks to [@windowshopr](https://github.com/windowshopr) for opening the issue [#78](#78) at GitHub. Check the [Parallel Processing in PyGAD](https://pygad.readthedocs.io/en/latest/README_pygad_ReadTheDocs.html#parallel-processing-in-pygad) section for more information and examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The parent_indices returned by pygad.GA.tournament_selection are actually the best indices selected from the K rand_indices. Within this method parents_indices are updated as followed:
parents_indices.append(selected_parent_idx)where I believe it should be changed to:
parents_indices.append(rand_indices[selected_parent_idx])The text was updated successfully, but these errors were encountered: