Skip to content

Fix yesqa hook #7843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2022
Merged

Fix yesqa hook #7843

merged 3 commits into from
Oct 29, 2022

Conversation

Cjkjvfnby
Copy link
Contributor

Describe your change:

I have noticed that yesqa is not working as the flake8 plugin.
It should be installed as a separate hook.

To have exactly the same flake8 setting plugins should be installed on both hooks.
I added a YAML anchor to keep plugins declaration in a single place.

Fix warnings that were raised by this hook across the repo.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 29, 2022
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 29, 2022
@cclauss
Copy link
Member

cclauss commented Oct 29, 2022

Please do not open new pull requests until November 1st. 2022 so I can focus on getting the open prs reviewed.

@cclauss cclauss merged commit 584e743 into TheAlgorithms:master Oct 29, 2022
@Cjkjvfnby Cjkjvfnby deleted the fix-yesqa-hook branch November 5, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants