Bernoullis equations #7200
Bernoullis equations #7200
Conversation
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
the
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
|
|
||
| def bernoulli_static_equation( | ||
| fluid_density: float, h: float, gravity: float = g, initial_pressure: float = 0 |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: h
| def bernoulli_full_equation( | ||
| fluid_density: float, | ||
| fluid_velocity: float = 0, | ||
| h: float = 0, |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: h
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
|
|
||
| def bernoulli_static_equation( | ||
| fluid_density: float, h: float, gravity: float = g, initial_pressure: float = 0 |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: h
| def bernoulli_full_equation( | ||
| fluid_density: float, | ||
| fluid_velocity: float = 0, | ||
| h: float = 0, |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: h
|
Hacktoberfest is strenuous for our team of active volunteer maintainers. That small team now has 200+ open pull requests to review. We have high standards for our submissions which are described in For these reasons, I will close all open pull requests failing tests so that our unpaid team has a smaller mountain to climb. If you want us to land your pull request, please read |
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.