Skip to content

Physics new code #4709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 6, 2021
Merged

Physics new code #4709

merged 13 commits into from
Sep 6, 2021

Conversation

avivfaraj
Copy link
Contributor

Describe your change:

Added new file to Physics folder. This file contain a function to calculate gamma function which is a common tool used in physics.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Sep 3, 2021
@Rohit-wed
Copy link

Rohit-wed commented Sep 4, 2021 via email

And also changed output to math notation
@QuantumNovice
Copy link
Contributor

One last request.
Can you rename the file to gamma_recursive.py and add it under maths directory?
We already have a gamma function based on quadrature. That seems like a suitable directory for it.

Good Work.👍 👍 👍

@avivfaraj avivfaraj requested a review from Kush1101 as a code owner September 6, 2021 14:20
@avivfaraj
Copy link
Contributor Author

One last request.
Can you rename the file to gamma_recursive.py and add it under maths directory?
We already have a gamma function based on quadrature. That seems like a suitable directory for it.

Good Work.👍 👍 👍

Done.

Thank You.

@QuantumNovice
Copy link
Contributor

@cclauss have a look at this.

@SayanMaity234
Copy link

It is working

@ghost ghost added the tests are failing Do not merge until tests pass label Sep 6, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Sep 6, 2021
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I modified the exceptions to more closely mimic the Python's Standard Library math.gamma() function.

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Sep 6, 2021
@cclauss cclauss merged commit 5d5831b into TheAlgorithms:master Sep 6, 2021
Copy link

@Dummy59 Dummy59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss
Copy link
Member

cclauss commented Sep 10, 2021

@Dummy59 Can you please explain what was done here?

shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
* added gamma_function

* Add files via upload

* Resolved issue with str.format

And also changed output to math notation

* Update gamma_function.py

* Rename physics/gamma_function.py to maths/gamma_recursive.py

* Fixes: TheAlgorithms#4709 Fixed issues for pre-commit test

* Fixes: TheAlgorithms#4709 solved issues with doctests

And comments

* Fixes: TheAlgorithms#4709 Added failed tests to doctest

* Align with Python's Standard Library math.gamma()

Replicate the exceptions of https://docs.python.org/3/library/math.html#math.gamma

* Update gamma_recursive.py

* Update gamma_recursive.py

* Update gamma_recursive.py

* Update gamma_recursive.py

Co-authored-by: Christian Clauss <[email protected]>
@avivfaraj avivfaraj deleted the physics_new_code branch April 5, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants